search

spullara / redis-protocol

Java client and server implementation of Redis
356 stars 134 forks source link

pub/sub improvements #9

Closed costin closed 12 years ago

costin commented 12 years ago

a. pmessage is not currently implemented (only message) b. it's not possible to remove a ReplyListener (after it was registered). c. a possible improvement to b), for misbehaved clients, would be to remove all listener once the connection closes or all the subscriptions (for channels and patterns) have been removed.

spullara commented 12 years ago

a) yep, don't know how i managed that one :) probably snowboarding all day ruined me b) true, seemed like an odd case but I will add the ability to remove them c) once the connection closes it won't receive any messages. even though they all removed more could be added. i'll add the remove listener and the developer can decide to remove themselves.

spullara commented 12 years ago

a) fixed b) removable c) I don't think it is necessary.

costin commented 12 years ago

Confirming the pub/sub problems are addressed.