[Enh Req] Open Terminals in new browser tab!

[MartynKeigher]

Quite a simple request here... request pretty much explains it!

Would be nice to have the terminal sessions, listed on the portal 'home page', open in different web tabs. That way when\if i want to navigate back to the portal for any reason (maybe course links & resources), I don't have to disconnect from my existing terminal session.

While I know I could just open the portal in a new tab itself... this is more of a 'quality of life' tweak.

Thanks.

://mk

[spurin]

Nice request.

I refrained from it initially as some browsers reject tabs being opened (and show a pop-up in the title bar which some users may miss).

Setting the target to blank in the hyperlink would do what is necessary for this to work.

I’ll see if I can add it as a portal environment variable like the LOCALHOST_OVERRIDE

Have just added this to my todo list, will keep you posted on progress on this here 👍

On 27 Jun 2021, at 18:10, Martyn T. Keigher @.***> wrote:

 Quite a simple request here... request pretty much explains it!

Would be nice to have the terminal sessions, listed on the portal 'home page', open in different web tabs. That way when\if i want to navigate back to the portal for any reason (maybe course links & resources), I don't have to disconnect from my existing terminal session.

While I know I could just open the portal in a new tab itself... this is more of a 'quality of life' tweak.

Thanks.

://mk

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[spurin]

Hi @MartynKeigher

Can you try this for me please, in your docker-compose.yaml, change the portal image so it's using -

diveintoansible-rc:portal

This is my release candidate branch. Then, in your docker-compose.yaml, set the following variable -

- OPEN_LINKS_AS_TABS=1

Hopefully, this should then give the functionality you were looking for. Let me know how you get on.

Cheers

• Update* - I did a minor change again at 20:24 GMT, if you pulled in the interim please try again

[MartynKeigher]

Testing this now... will report back shortly!

[MartynKeigher]

Container is failing to start, on the rc build. All others spin up fine. exit code 1, fairly immediately.

[spurin]

Thanks @MartynKeigher

Did you change any of the others or was it just the portal one?

The others, haven't been updated in a while so I'd only try the portal one with this.

Could you do another docker-pull as I did push a last minute fix, maybe docker hub hadn't propagated fully

[MartynKeigher]

Now it works! Nice little addition!!!

Thank you for both considering and implementing it so quick!

[MartynKeigher]

Its in RC build & working, so will close this issue. Up to the dev as to when, and\or if, it becomes part of master\main build.

[spurin]

@MartynKeigher

Thanks for your help 👍