sputt / wabbitemu

Wabbitemu is a Z80 TI Calculator emulator
http://wabbitemu.org
MIT License
294 stars 31 forks source link

Touch buttons are misaligned under default settings #22

Open mkrupczak3 opened 4 years ago

mkrupczak3 commented 4 years ago

Description:

The default configuration of the app on later versions of android (e.g. 11), WabbitEMU is configured by default to hide "touchbar buttons" during use of the app.

Unfortunately, this causes a noticable "misalignment" whereby the appearance of each calculator button and the location necessary to tap to activate it are discoupled. For instance, each and every button on screen would need to be tapped a small distance above their apparent location on the screen, no matter the calculator emulated. The difference is noticeable enough to interfere with normal use of the app.

Steps to reproduce:

On a phone with android 11 (e.g. Pixel 4a)

  1. Launch the app
  2. Setup a TI-83 ROM file and launch

Workaround:

In the settings menu of the app, deselect the "hide touchbar buttons" option. The button locations and their on-screen counterparts will now be properly aligned.

mkrupczak3 commented 4 years ago

https://www.reactiongifs.us/wp-content/uploads/2016/06/doing_my_part_starship_troopers-1.gif

mkrupczak3 commented 4 years ago

My guess would be that if the developer coded in some kind of "offset" for the location of the buttons onscreen with and without the touchbar hidden, that the offset is a fixed value instead of gathered from an API.

On Android 11 (10?), the wider "3 touch button" bar at the bottom was replaced with a thinner single bar for "home", while the multitask and back functions were delegated to swiping gestures.

If such an offset was incorrect due to this discrepancy, that could explain this bug.

mkrupczak3 commented 4 years ago

Please don't make me dig through this code and submit a pull request

(Huge fan of the app btw)

Hubcapp commented 3 years ago

can confirm this as an issue

nate-moo commented 2 years ago

This is an issue with both 3-button and gesture navigation. The workaround fixes on both nav modes