search

spyder-ide / pyls-spyder

Spyder extensions for the python language server (pyls)
MIT License
0 stars 6 forks source link

Some issues with special comments in the outline explorer #8

Closed jnsebgosselin closed 3 years ago

jnsebgosselin commented 4 years ago

After PR spyder-ide/spyder#13885, a "special comment" is shown in the outline explorer, regardless of the number of consecutive - following the #.

Before the outline explorer migration to the pyls, a special comment was registered only when there was exactly 4 consecutive - following the #. I think this rule should be added back in the current implementation of this feature.

For example, the outline explorer is showing special comments for the horizontal separator that are sometimes present in the header of spyder's file.

image

Versions

eafpres commented 4 years ago

As I understand it, the pattern #### should also work as a special comment, and does not work in 4.2.0

jnsebgosselin commented 3 years ago

@ccordoba12 I'm under the impression that this issue is not fully resolved. There is no "Unnamed comment #" added anymore, but the long -------------... are still registered as special comment. Is this working as intended? This is with pyls-spyder version 0.2.1.

image

ccordoba12 commented 3 years ago

Please open a new issue about it.