search

spyder-ide / qtawesome

Iconic fonts in PyQt and PySide applications
https://qtawesome.readthedocs.io/en/latest/index.html
MIT License
802 stars 105 forks source link

QtAwesome 1.2.0 incompatible with PySide2 #210

Closed Czaki closed 1 year ago

Czaki commented 1 year ago

Thanks for your project, but the last release (1.2.0) brings regression with the PySide2 backend

my tests start failing on the internal QtAwesome import:

      from qtpy.QtGui import (QColor, QFont, QFontDatabase, QIcon, QIconEngine,
  E   ImportError: cannot import name 'QGlyphRun' from 'qtpy.QtGui' (/tmp/tox/py310-PySide2-all/lib/python3.10/site-packages/qtpy/QtGui.py)

here log: https://github.com/4DNucleome/PartSeg/actions/runs/3283881224/jobs/5409179903#step:8:49

dalthviz commented 1 year ago

Hi @Czaki thanks for the feedback! Indeed seems like PySide2 doesn't have QGlyphRun :/ . I think we will need to add a try-catch/validation to handle this and probably add PySide2 on the CI to prevent incompatibilities in the future :+1: