spyder-ide / spyder-docs

Documentation for Spyder, the Scientific Python Development Environment
https://docs.spyder-ide.org
MIT License
33 stars 282 forks source link

Explicitly check value of deploy vars in GHA to ensure correct logic #376

Closed CAM-Gerlach closed 1 month ago

CAM-Gerlach commented 1 month ago

Pull Request

Pull Request Checklist

Description of Changes

The final production deploy of #367 failed because the deploy logic was off; these checks of the GHA env vars need to explicitly check for '1' and not just truthy as '0' is also truthy. This should fix it. Also, see if the yet another brabd new linkcheck error re-occurs.

CAM-Gerlach commented 1 month ago

Going ahead and merging since this fixes an urgent deploy issue and can only be fully tested directly on master.