spyder-ide / spyder-notebook

Jupyter notebook integration with Spyder
Other
532 stars 130 forks source link

select "No" to close other files associated with console opened using spyder-notebook causes error #373

Closed richlysakowski closed 1 month ago

richlysakowski commented 2 years ago

Description

What steps will reproduce the problem?

I had severall notebooks open in spyder-notebook, and closed one with the "X" button in the spyder-notebook tab. It asked me if I wanted to close all other notebooks associated with this console/kernel. I clicked "No" button and got this error message.

Traceback

  File "C:\ProgramData\Anaconda3\envs\webscrapers\lib\site-packages\spyder\plugins\ipythonconsole\widgets\client.py", line 175, in <lambda>
    self.exit_callback = lambda: plugin.close_client(client=self)
  File "C:\ProgramData\Anaconda3\envs\webscrapers\lib\site-packages\spyder\plugins\ipythonconsole\plugin.py", line 1238, in close_client
    self.clients.remove(client)
ValueError: list.remove(x): x not in list

Versions

Dependencies


# Mandatory:
atomicwrites >=1.2.0            :  1.4.0 (OK)
chardet >=2.0.0                 :  4.0.0 (OK)
cloudpickle >=0.5.0             :  1.6.0 (OK)
diff_match_patch >=20181111     :  20200713 (OK)
intervaltree >=3.0.2            :  3.0.2 (OK)
IPython >=7.6.0                 :  7.16.1 (OK)
jedi =0.17.2                    :  0.17.2 (OK)
jsonschema >=3.2.0              :  3.2.0 (OK)
keyring >=17.0.0                :  23.0.1 (OK)
nbconvert >=4.0                 :  6.0.7 (OK)
numpydoc >=0.6.0                :  1.1.0 (OK)
paramiko >=2.4.0                :  2.7.2 (OK)
parso =0.7.0                    :  0.7.0 (OK)
pexpect >=4.4.0                 :  4.8.0 (OK)
pickleshare >=0.4               :  0.7.5 (OK)
psutil >=5.3                    :  5.8.0 (OK)
pygments >=2.0                  :  2.9.0 (OK)
pylint >=1.0                    :  2.8.3 (OK)
pyls >=0.36.2;<1.0.0            :  0.36.2 (OK)
pyls_black >=0.4.6              :  0.4.6 (OK)
pyls_spyder >=0.3.2             :  0.3.2 (OK)
qdarkstyle >=2.8;<3.0           :  2.8.1 (OK)
qtawesome >=0.5.7               :  1.0.2 (OK)
qtconsole >=5.0.3               :  5.1.0 (OK)
qtpy >=1.5.0                    :  1.9.0 (OK)
rtree >=0.8.3                   :  0.9.4 (OK)
setuptools >=39.0.0             :  49.6.0.post20210108 (OK)
sphinx >=0.6.6                  :  4.0.2 (OK)
spyder_kernels >=1.10.2;<1.11.0 :  1.10.2 (OK)
textdistance >=4.2.0            :  4.2.1 (OK)
three_merge >=0.1.1             :  0.1.1 (OK)
watchdog >=0.10.3;<2.0.0        :  1.0.2 (OK)
zmq >=17                        :  22.1.0 (OK)

# Optional:
cython >=0.21                   :  0.29.23 (OK)
matplotlib >=2.0.0              :  3.3.4 (OK)
numpy >=1.7                     :  1.19.5 (OK)
pandas >=1.1.1                  :  1.1.5 (OK)
scipy >=0.17.0                  :  1.5.3 (OK)
sympy >=0.7.3                   :  1.8 (OK)

# Spyder plugins:
spyder_notebook                 :  0.3.2 (OK)
spyder_terminal                 :  0.5.0 (OK)
ccordoba12 commented 2 years ago

Hey @richlysakowski, thanks for reporting. I'm going to move this issue to the Spyder-notebook repository because it needs to be solved there.

For the future, please report all issues related to that plugin there.

jitseniesen commented 1 month ago

I can't reproduce this and the code has changed quite a bit in the mean time, so I am hoping that this has been resolved. If you see the same issue again, please re-open.