search

spyder-ide / spyder-vim

A plugin for Spyder to enable Vim keybindings
https://www.spyder-ide.org
MIT License
126 stars 26 forks source link

PR: Move CI to GitHub actions #46

Closed bgallois closed 4 years ago

goanpeca commented 4 years ago

Awesome work @bgallois 🥳 !

It seems we have a failing test on window

spyder_vim/tests/test_vim.py::test_p_command_char_mode FAILED

Do you have access to a Windows VM to try to debug the problem?

Thanks for putting this together.

goanpeca commented 4 years ago

(I have disabled Circle CI so on the next push that failing check should go away.)

bgallois commented 4 years ago

@goanpeca I'm investigating the Windows failing test. Performed manually in Spyder the test is successful but performed by pytest an extra blank space is added at the beginning of the selected text. Still working on it.

goanpeca commented 4 years ago

@goanpeca I'm investigating the Windows failing test. Performed manually in Spyder the test is successful but performed by pytest an extra blank space is added at the beginning of the selected text. Still working on it.

Yeah, this sometimes happens, let's add a skip if the test runs on windows and on CI, so that local tests on windows can still be run.

goanpeca commented 4 years ago

Something like:

@pytest.mark.skipif(os.name == 'nt' and bool(os.environ('CI')), reason="Does not work on windows CI!")