Closed ryohei22 closed 1 year ago
Thank you for your contribution.
Don't worry about failed test. The failure in our tests seems unrelated to this.
I leaved a simple code suggestion.
I leaved a simple code suggestion.
Where is your suggestion? Sorry if I misunderstood.
I leaved a simple code suggestion.
Where is your suggestion? Sorry if I misunderstood.
I'm sorry. I forgot submitting the suggestion.
Thank you for your suggestion. It looked totally better, so I adopted it.
It seems we need to fix our tests first, as @ok97465 mentioned.
@ok97465, do you have time to take a look at that?
It seems we need to fix our tests first, as @ok97465 mentioned.
@ok97465, do you have time to take a look at that?
Yes, I will do this weekend.
Can we merge this PR before fixing the test?
Yes, I will do this weekend.
Great!
Can we merge this PR before fixing the test?
I don't think that's a good idea because we don't know if it breaks the test suite somehow. So, it's better to fix it first and then ask @ryohei22 to merge with master
afterwards.
@ryohei22, please rebase this one as well.
Merging according to @ok97465's feedback.
Description of the change
I fixed a bug.
Steps to occur the bug
In the NORMAL mode of Vim, when you only type ":", the Issue reporter shows up.