spyder-ide / spyder-vim

A plugin for Spyder to enable Vim keybindings
https://www.spyder-ide.org
MIT License
126 stars 26 forks source link

PR: Fix a bug when introducing commands in normal mode #87

Closed ryohei22 closed 1 year ago

ryohei22 commented 1 year ago

Description of the change

I fixed a bug.

Steps to occur the bug

In the NORMAL mode of Vim, when you only type ":", the Issue reporter shows up.

ok97465 commented 1 year ago

Thank you for your contribution.

Don't worry about failed test. The failure in our tests seems unrelated to this.

I leaved a simple code suggestion.

ryohei22 commented 1 year ago

I leaved a simple code suggestion.

Where is your suggestion? Sorry if I misunderstood.

ok97465 commented 1 year ago

I leaved a simple code suggestion.

Where is your suggestion? Sorry if I misunderstood.

I'm sorry. I forgot submitting the suggestion.

ryohei22 commented 1 year ago

Thank you for your suggestion. It looked totally better, so I adopted it.

ccordoba12 commented 1 year ago

It seems we need to fix our tests first, as @ok97465 mentioned.

@ok97465, do you have time to take a look at that?

ok97465 commented 1 year ago

It seems we need to fix our tests first, as @ok97465 mentioned.

@ok97465, do you have time to take a look at that?

Yes, I will do this weekend.

Can we merge this PR before fixing the test?

ccordoba12 commented 1 year ago

Yes, I will do this weekend.

Great!

Can we merge this PR before fixing the test?

I don't think that's a good idea because we don't know if it breaks the test suite somehow. So, it's better to fix it first and then ask @ryohei22 to merge with master afterwards.

ccordoba12 commented 1 year ago

@ryohei22, please rebase this one as well.

ccordoba12 commented 1 year ago

Merging according to @ok97465's feedback.