Closed ryohei22 closed 1 year ago
I wish I could implement block text pasting. By the way, I noticed that I can yank multiple lines and paste them with the p command. Is this different from block text pasting mentioned in the code?
I wish I could implement block text pasting. By the way, I noticed that I can yank multiple lines and paste them with the p command. Is this different from block text pasting mentioned in the code?
Thank you for your PR. When spyder-vim says block, it means visual mode, not V-Line mode.
@ryohei22, the failure in our tests seems legitimate. Do you know how to run our tests locally so you can take a look at it?
@ccordoba12 Thank you for making sure that. I know how to run the tests. I have a deadline at the end of this month, so it may be late to work on this. Sorry for the late update.
Even tho I said I might make you wait, now my changes passed all of the tests.
@ok97465, what do you think about @ryohei22's fix?
@ccordoba12 This PR seems to resolve the issue.
Description of Changes
I modified the
p()
function to not run when there is nothing to paste.Description of the bug
There was a bug with the p command as reported in issue #86. When there is nothing to paste, more specifically, when executing the p command before any of the d, dd, y, and yy commands, the
P()
function is executed without a required valuable. I noticed that onlychar
,line
, andblock
were expected as values for theselection_state
parameter inwidgets.py
but it can beFalse
as well.Issue(s) Resolved
Fixes #86. The issue occurs because
:y
is not implemented yet and doesn't yank anything.