spyder-ide / spyder-website

The new Spyder website, built with Svelte
http://www.spyder-ide.org/
MIT License
2 stars 4 forks source link

Add new About page with project details and team members #13

Closed conradolandia closed 1 week ago

conradolandia commented 1 month ago

Created an "About" page with data from our contributors. Also that item was added to the main menu and spacing was standardized for menu items.

TODO:

netlify[bot] commented 1 month ago

Deploy Preview for spyder-website-preview ready!

Name Link
Latest commit 13994f84a78f782f134c5e96df68cdb8e70cf876
Latest deploy log https://app.netlify.com/sites/spyder-website-preview/deploys/671bd7a8c8ee450008e5733d
Deploy Preview https://deploy-preview-13--spyder-website-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

conradolandia commented 1 month ago

I donΒ΄t have any issue with your suggestions CAM, but we will need to wait for @ccordoba12 to give his input

CAM-Gerlach commented 1 month ago

>be Andres >go to Files Changed tab

![image](https://github.com/user-attachments/assets/35607357-76a3-4a68-b849-3ecba24b378c)

click Add suggestion to batch

image

image

repeat on other suggestions

>click Commit Suggestions

![image](https://github.com/user-attachments/assets/d148fe2e-22d0-48a9-a317-8f954c130175)

write banger commit message

>click Commit changes

![image](https://github.com/user-attachments/assets/ca658a9e-69b3-4eda-84d5-8b5d51155122)

whole dev team cheered

conradolandia commented 1 month ago

be Andres >go to Files Changed tab

click Add suggestion to batch

repeat on other suggestions

click Commit Suggestions

write banger commit message

click Commit changes

whole dev team cheered

Got it, thank you for your detailed tutorial.

conradolandia commented 1 month ago

I'm still waiting for the missing data of contributors, but the infrastructure to handle it is already there, so maybe this can be reviewed @CAM-Gerlach? check the tooltip on @ccordoba12's profile in the About page. We will create the diversity and userbase sections in a future PR.

ccordoba12 commented 2 weeks ago

@conradolandia, the text suggestions left by @CAM-Gerlach were for me to review since I was the one that came up with the initial text (fortunately I was ok with most of them, except one that I already fixed). So, please don't be so eager to apply them for next time. Thanks!

In addition, you can add multiple suggestions in a single commit for next time (instead of applying them one by one). That's described here (see Add suggestion to batch), which is also the way we prefer to apply suggestions in all our repos.

conradolandia commented 2 weeks ago

Thanks @ccordoba12 for the heads up. I did the first one, and then tried the batch, but for some reason, the buttons appeared disabled for me. I will wait for your comments before approving anything.