Find in files directory selection does not load when long names in history

[jvendrig]

Issue Report Checklist

• [X] Searched the issues page for similar reports
• [X] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
• [X] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
• [ ] Could not reproduce inside jupyter qtconsole (if console-related)
• [X] Tried basic troubleshooting (if a bug/error)
  • [X] Restarted Spyder
  • [X] Reset preferences with spyder --reset
  • [X] Reinstalled the latest version of Anaconda
  • [X] Tried the other applicable steps from the Troubleshooting Guide
• [X] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description

Windows, launched from Anaconda Navigator.

The "Find in files" combobox to select the search directory does not load when

• Spyder is restarted (i.e. spyder.ini is read), and
• spyder.ini find_in_files path_history contains particular values, where my hypothesis is that if one of the strings in the list is longer than ~40 characters, there's an issue loading the combobox widget

As a consequence it is not possible to select any search directory, and search is limited to whatever directory it is stuck in.

Note: when the path_history is empty/clean, there is no issue searching in these same directories while Spyder is active. The issue seems to occur only when these directories are committed to the ini.

Workarounds:

• Reset preferences with spyder --reset
• Manually edit spyder.ini to remove history

What steps reproduce the problem?

1. Fresh start: spyder.ini, find_in_files, path_history = []
2. In Find | Search in select a directory for which the string overflows the display in the combo box
3. Perform the search (should work fine)
4. Exit Spyder (so that spyder.ini, find_in_files, path_history = ['c:\directory\withlongname\thatyoujustselected'])
5. Start Spyder

I first noticed this problem at a random time without knowingly restarting Spyder, but it's hard to reproduce.

What is the expected output? What do you see instead?

Expected: Find | Search, Select a directory (new or from history) option Actual: no means to Select a directory (new or from history)

Paste Traceback/Error Below (if applicable)

Versions

• Spyder version: 5.4.3 (and earlier)
• Python version: 3.9.16
• Qt version: 5.15.2
• PyQt version: 5.15.7
• Operating System name/version: Windows 10

Dependencies

# Mandatory:
atomicwrites >=1.2.0                             :  1.4.0 (OK)
chardet >=2.0.0                                  :  4.0.0 (OK)
cloudpickle >=0.5.0                              :  2.2.1 (OK)
cookiecutter >=1.6.0                             :  1.7.3 (OK)
diff_match_patch >=20181111                      :  20200713 (OK)
intervaltree >=3.0.2                             :  3.1.0 (OK)
IPython >=7.31.1,<9.0.0,!=8.8.0,!=8.9.0,!=8.10.0 :  8.12.0 (OK)
jedi >=0.17.2,<0.19.0                            :  0.18.1 (OK)
jellyfish >=0.7                                  :  0.9.0 (OK)
jsonschema >=3.2.0                               :  4.17.3 (OK)
keyring >=17.0.0                                 :  23.13.1 (OK)
nbconvert >=4.0                                  :  6.5.4 (OK)
numpydoc >=0.6.0                                 :  1.5.0 (OK)
paramiko >=2.4.0                                 :  2.8.1 (OK)
parso >=0.7.0,<0.9.0                             :  0.8.3 (OK)
pexpect >=4.4.0                                  :  4.8.0 (OK)
pickleshare >=0.4                                :  0.7.5 (OK)
psutil >=5.3                                     :  5.9.0 (OK)
pygments >=2.0                                   :  2.11.2 (OK)
pylint >=2.5.0,<3.0                              :  2.16.2 (OK)
pylint_venv >=2.1.1                              :  2.3.0 (OK)
pyls_spyder >=0.4.0                              :  0.4.0 (OK)
pylsp >=1.7.2,<1.8.0                             :  1.7.2 (OK)
pylsp_black >=1.2.0                              :  1.2.1 (OK)
qdarkstyle >=3.0.2,<3.2.0                        :  3.0.2 (OK)
qstylizer >=0.2.2                                :  0.2.2 (OK)
qtawesome >=1.2.1                                :  1.2.2 (OK)
qtconsole >=5.4.2,<5.5.0                         :  5.4.2 (OK)
qtpy >=2.1.0                                     :  2.2.0 (OK)
rtree >=0.9.7                                    :  1.0.1 (OK)
setuptools >=49.6.0                              :  66.0.0 (OK)
sphinx >=0.6.6                                   :  5.0.2 (OK)
spyder_kernels >=2.4.3,<2.5.0                    :  2.4.3 (OK)
textdistance >=4.2.0                             :  4.2.1 (OK)
three_merge >=0.1.1                              :  0.1.1 (OK)
watchdog >=0.10.3                                :  2.1.6 (OK)
zmq >=22.1.0                                     :  25.0.2 (OK)

# Optional:
cython >=0.21                                    :  None (NOK)
matplotlib >=3.0.0                               :  3.6.2 (OK)
numpy >=1.7                                      :  1.24.3 (OK)
pandas >=1.1.1                                   :  1.5.2 (OK)
scipy >=0.17.0                                   :  1.10.1 (OK)
sympy >=0.7.3                                    :  None (NOK)

[jvendrig]

Another workaround is to expand the pane horizontally such that the longest path fits in the combobox. It will then become available. However, there is another bug in Spyder that prevent expanding the pane in certain situations.

[dalthviz]

Hi @jvendrig thank you for the feedback and the issue description! I think I was able to reproduce it:

Will try to fix this in a future release :+1: