search

spyder-ide / spyder

Official repository for Spyder - The Scientific Python Development Environment
https://www.spyder-ide.org
MIT License
8.25k stars 1.6k forks source link

PR: Fix error when plugins required for tabification are unavailable (Layout) #22199

Closed hmaarrfk closed 2 months ago

hmaarrfk commented 3 months ago

in developing https://github.com/spyder-ide/spyder/pull/22196 I found that this was a useful backport

Affirmation

By submitting this Pull Request or typing my (user)name below, I affirm the Developer Certificate of Origin with respect to all commits and content included in this PR, and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

Mark Harfouche - hmaarrfk

ccordoba12 commented 2 months ago

This is the right fix but there's one additional problem: Help is listed as the plugin to which many other plugins need to tabified next to. For instance:

https://github.com/spyder-ide/spyder/blob/141f0fb90143aca2405f72bf4709c32b0530f7e2/spyder/plugins/pylint/plugin.py#L30-L38

So, please look for all those instances and add Plugins.VariableExplorer to that list. And if it's not a list, please make it one.

Finally, after doing that please rebase on top of the latest 5.x to get the fixes to our tests.

hmaarrfk commented 2 months ago

Finally, after doing that please rebase on top of the latest 5.x to get the fixes to our tests.

Sorry about that i thought i rebased earlier today, but maybe my branch didn't pull in correctly.

hmaarrfk commented 2 months ago

PS. i feel like i am updated on the 5.x branch image

hmaarrfk commented 2 months ago

I pulled in https://github.com/spyder-ide/spyder/pull/22237 to let the tests run successfully

ccordoba12 commented 2 months ago

I pulled in https://github.com/spyder-ide/spyder/pull/22237 to let the tests run successfully

Sorry, I forgot we didn't apply the Numpy 2.0 fix to this branch.

hmaarrfk commented 2 months ago

3 distinct commits.

Let me know if you need other things on this branch.

ccordoba12 commented 2 months ago

Let me know if you need other things on this branch.

Please rebase on top of the latest 5.x to remove from here the commit in PR #22237.

hmaarrfk commented 2 months ago

done.

hmaarrfk commented 2 months ago

and fyi, forward port here: https://github.com/spyder-ide/spyder/pull/22238

ccordoba12 commented 2 months ago

and fyi, forward port here: https://github.com/spyder-ide/spyder/pull/22238

Thanks, but the PRs against 5.x are merged to master as well. So, your extra PR wasn't really necessary (sorry if I wasn't clear enough about that).