Closed ma-sadeghi closed 3 years ago
Hey @ma-sadeghi, thanks for reporting. I'm going to move this issue to our ux-improvements repo, where we have discussions like this.
The top-left/right corners are not round (like the bottom corners)
That's by design.
The splash screen is low-resolution and doesn't appear sharp on high-res monitors
That's worrisome. Could you post a screenshot of how it looks in a high-res monitor?
the background photo, in my opinion, doesn't really add any more value to the splash screen
That's certainly your opinion and we disagree with it. Please see the end of our video for the rationale:
Thanks for your quick reply. Here's a screenshot from a 4K monitor:
Thanks @ma-sadeghi! I agree that the image and especially the text have a lot of pixelation.
@isabela-pf, is there something we can do about it?
Also, here's an screenshot of my taskbar:
in which the Spyder icon is low-resolution (compare it with the one next to it on the left, which is for Mathematica, or VS Code, etc.)
I couldn't reproduce this issue in my HiDPI screen, the icon looks pretty defined
@andfoy could you right click on the icon and let me know where you .ico is located? Mine is in
%USERPROFILE%\mambaforge\Scripts\spyder.ico
which I converted to PNG so GitHub allows me to upload it:
Ok, I think I know what the problem is: the size of our ico file is too small (32x32 px) for high dpi screens. In contrast, the VSCode ico file is 128x128 px (just checked it).
So I think it's just a matter of increasing the size and we'll be good. @isabela-pf, could you take care of that? Thanks!
This is the file whose size we need to increase:
https://github.com/spyder-ide/spyder/blob/5.x/img_src/spyder.ico
@ccordoba12 Great, thanks! Could you maybe do the same for the splash screen?
Although the problem for that is different, @isabela-pf is already working on a fix. Both things will be available in Spyder 5.2.0, to be be released at the end of September,
Thanks to @isabela-pf's hard work, this fix will be available in our 5.1.2, to be released in a day or two.
I updated my Spyder to 5.1.2, but the splash screen is still low-res (although better than what it used to be). For comparison, here's the splash screen of Mathematica on the same monitor:
I think that's the best we can do because we're using a photo and not just a figure.
I'm a bit surprised that the logo and "Version 5" still look pixelated. @isabela-pf, what do you think?
I'm sorry to hear it. I know it's not what anyone wants to hear, but I'm not sure what to do next. The last PR remade the splash screen with me double checking it wasn't actually converting some part of the SVG to a bitmap early by accident, and @steff456 and @andfoy corrected the way the splash screen is called for the same reason.
Can I ask if it's just the splash screen now, or also the icons? It looks like they are still a little blurry in the screen shot you posted.
@isabela-pf Thanks for your reply. The low-res taskbar icon you see in my screenshot is because it hasn't been updated. I removed it and re-added it and it got fixed. The only issue is the splash screen.
@ma-sadeghi, I'm afraid there's nothing else we can do to enhance the resolution of the splashscreen. As @isabela-pf already mentioned Qt expects a bitmap to be loaded as a splashscreen, we cannot load a high res svg because it will be converted to a bitmap inevitably loosing resolution. Maybe in future versions of Qt they will change this restriction, and we will be able to load an image rather than a bitmap.
Here's the splash screen that I see with my Spyder v5.1.1:
I think it could be improved on three fronts: