sq / JSIL

CIL to Javascript Compiler
http://jsil.org/
Other
1.73k stars 241 forks source link

Implemented Regex.IsMatch(string, string) #1012

Open wklingler opened 8 years ago

kg commented 8 years ago

I'm not sure I like this, isn't ecmascript regex mode different from the .net default? This would break app logic

kg commented 8 years ago

Hmm, that's probably close enough. I'll think about merging it. Thanks!

wklingler commented 8 years ago

Is there something that makes you nervous that I could look into more?

kg commented 8 years ago

I'm pretty sure there are some cases where .NET regex syntax would parse but produce the wrong results in javascript, which could cause very confusing failures. It would be ideal to write a .NET regex parser that rejects incompatible regexes. This might be OK though

wklingler commented 8 years ago

That makes sense. I'll see if I can come up with something like that sometime.