search

sq8vps / vp-digi

VP-Digi - a functional, cheap, easy to assemble and configure STM32-based APRS digipeater controller with built-in KISS modem.
https://sq8l.pzk.pl/index.php/vp-digi-cheap-and-functional-aprs-digipeater-controller-with-kiss-modem/
GNU General Public License v3.0
47 stars 14 forks source link

Receiving commands appears to break when using a CrLf (\r\n) line ending #24

Closed DeflateAwning closed 1 year ago

DeflateAwning commented 1 year ago

Steps to reproduce:

  1. Turn on device, flash. connect to UART1 with a 9600 uart-to-usb converter. Using RealTerm.
  2. Send monitor\n, where \n means the newline character (and not those literal characters).
  3. Send version\n. Everything works.
  4. Send version\n\r. Everything works fine. This is a weird one that probably rarely happens.
  5. Send version\r. Everything works fine.
  6. Send version\r\n. Observe no response. Observe that device goes unresponsive.

It appears that after step 5, the device requires a reboot to function.

This isn't the worst bug, but thought it was worth pointing out. In the README or on your website, you should mention the expected EOL character (esp. if you don't fix this behaviour).

sq8vps commented 1 year ago

Resolved in 1.3.0, or at least I was unable to reproduce the issue