search

sqfmi / watchy-docs

Watchy Documentation Website
MIT License
33 stars 55 forks source link

Make "X marks the spot" preview compatible with EasyPrivacy adblock list #38

Closed synthead closed 2 years ago

synthead commented 2 years ago

Fixes https://github.com/sqfmi/watchy-docs/issues/37.

This PR updates the preview for "X marks the spot" so that the EasyPrivacy adblock list doesn't erroneously block x.gif?raw=true as a spy pixel (https://en.wikipedia.org/wiki/Spy_pixel).

Copy/pasting the content from :point_up::

With EasyPrivacy added to an adblocker (website, direct link), the "X marks the spot" watch face image on Watch Faces page does not load, and it looks like this:

image

This is likely because of the URL to the preview, which has x.gif? in the name:

https://github.com/sqfmi/watchy-docs/blob/a63d44aabf0e4219d576c3efa23997bed34f3a4d/src/pages/watchfaces/watchfaces.json#L308-L316

x.gif is a typical filename used for "spy pixels," and the adblocker cannot discern that this is actually a desired image. More information about this here: https://en.wikipedia.org/wiki/Spy_pixel

Here is where this list blocks this image:

image

Steps to reproduce

  1. Install uBlock Origin to your browser.
  2. Add EasyPrivacy list from its website.
  3. Observe that x.gif for this watch face is not displayed.

Suggested fix

Use the direct link to raw.githubusercontent.com instead:

https://raw.githubusercontent.com/theRealc2c2/x-marks-the-spot/main/x.gif

The link currently shipped to watchfaces.json redirects to this link :point_up: anyway:

image

synthead commented 2 years ago

Is there anything you'd like me to change in this PR?