Closed 4kimov closed 10 months ago
Short version: New bug was found in the spec repo. It was filtering blocklist against the alphabet incorrectly in the constructor, and the issue showed up when using lowercase blocklist in uppercase-only alphabet.
More detailed version: See pull request #7 discussion.
New test was added to the spec: https://github.com/sqids/sqids-spec/commit/02d61161ce82df1d5c9f75f6cf468bc396e292d9 Code to fix the issue: https://github.com/sqids/sqids-spec/pull/7/commits/c9c8b2874d21ad2c93e49d3c2b737a2b65853593
jesperoman
commented
10 months ago
Short version: New bug was found in the spec repo. It was filtering blocklist against the alphabet incorrectly in the constructor, and the issue showed up when using lowercase blocklist in uppercase-only alphabet.
More detailed version: See pull request #7 discussion.
New test was added to the spec: https://github.com/sqids/sqids-spec/commit/02d61161ce82df1d5c9f75f6cf468bc396e292d9 Code to fix the issue: https://github.com/sqids/sqids-spec/pull/7/commits/c9c8b2874d21ad2c93e49d3c2b737a2b65853593