search

sqitchers / docker-sqitch

Docker Image packaging for Sqitch
MIT License
36 stars 39 forks source link

Update README - Add note for localhost database server connection #10

Closed franciscohanna92 closed 5 years ago

franciscohanna92 commented 5 years ago

Add note for when running a local database server a trying to connect to it from the sqitch container.

This was discussed in #9.

theory commented 5 years ago

Well that covers only the MySQL case, and sound like it assumes the user would only be using MySQL. Perhaps should create a list to document how to do it for each engine that can be running on the host (that is, all but SQLite and Snowflake).

theory commented 5 years ago

This is a workable hack, but a hack all the same. The more correct and general approach is to use host.docker.internal or, until docker/libnetwork#2348 gets merged and released, use a NAT gateway container to forward traffic to the Docker host. So I'm closing this PR in favor of 66b22b3.