search

sqitchers / homebrew-sqitch

Homebrew Formulas for Sqitch
22 stars 10 forks source link

Use Postgres and MySQL clients instead of servers #57

Closed theory closed 1 year ago

theory commented 1 year ago

Depend on the libpq and mysql-client formulas instead of postgresql and mysql. This allows Sqitch to manage Postgres and MySQL databases but does not force the user to install the servers to support them.

Brought about by the warning recently added to Homebrew that deprecates the postgresql dependency in favor of specific versions of Postgres. Thanks to @ZhongRuoyu for the pointers in the discussion of this issue and to @Alam080 for reporting it (resolves #56).

theory commented 1 year ago

Welp since none of those issues are directly related to this PR, but to general cleanup, I'm gonna merge it. Thank you!

On those items:

  1. I'll try that
  2. I don't recall why I used :optional instead of :recommended; it has been years. But looking at the relevant bit from the Cookbook, I'm guessing it was because this formula explicitly sets the options, creating --with-* options, which emulates the behavior of :optional, whereas :required implicitly creates --without-* options, which the formulae does not do.
  3. Again, don't recall why those are there, except that something must not have worked without them. e02309c seems to confirm that. Note that they're only set when building from Git, which is rare. I'm almost certain something compiled by the installing code didn't work without them.
theory commented 1 year ago

Made those changes in #58. Seem to work fine!