search

sqitchers / homebrew-sqitch

Homebrew Formulas for Sqitch
22 stars 10 forks source link

Simplify optional dependencies and remove unneeded environment variables. #58

Closed theory closed 1 year ago

theory commented 1 year ago

As suggested n #57.

Turns out we don't need to pass :recommended to depends_on for dependences added by option flags, so remove them and covert some of the option checks to one-liners for simpler reading.

At some point it seemed necessary to set build environment variables when building from Git. Apparently not anymore. Still need to include the gettext formula's bin directory in the path; otherwise dzil build fails because it can't find msgfmt to build the localization libraries.

theory commented 1 year ago

Between this PR and #57, I'm thinking it might be possible to create a formula for the core Homebrew repository. I'd remove all the options and just depend on the formulas required for all the engines (libpq, mysql-client, sqlite, and libiodbc). Would be much simpler.

ZhongRuoyu commented 1 year ago

Thanks!

I'm thinking it might be possible to create a formula for the core Homebrew repository

We will review a PR.