sql-bi / Bravo

Bravo for Power BI
MIT License
351 stars 92 forks source link

Crash when trying to add time intelligence on a measure that sums values from two other measures #693

Open Eiriksra opened 1 year ago

Eiriksra commented 1 year ago

Describe the problem

Error HTTP/500: Internal Server Error. Failed to save modifications to the server. Error returned: 'The value for 'Margin YTD' cannot be determined. Either the column doesn't exist, or there is no current row for this column. The value for 'Item Sales Amount (LCY) YTD' cannot be determined. Either the column doesn't exist, or there is no current row for this column. The value for 'Margin YTD' cannot be determined. Either the column doesn't exist, or there is no current row for this column. The value for 'Net Sales LCY YTD' cannot be determined. Either the column doesn't exist, or there is no current row for this column. The value for 'Margin YTD' cannot be determined. Either the column doesn't exist, or there is no current row for this column. The value for 'Net Sales LCY YTD' cannot be determined. Either the column doesn't exist, or there is no current row for this column. A circular dependency was detected: DateAutoTemplate[DateAutoTemplate], Sales Headers[RecoveredDates], Date[Date], Date[Date][Date], Date[Date], DateAutoTemplate[DateWithTransactions], DateAutoTemplate[DateWithTransactions][DateAutoTemplate], DateAutoTemplate[DateAutoTemplate]. '.

Bravo version

1.0.4 (1.0.8577.19837)

Tabular model

Power BI Desktop, import mode

Power BI

Power BI Desktop version June 2023

Steps to reproduce the behavior

No response

Additional context

No response

Screenshots

image

Anything else ?

Trace Id: 00-0e4b6bfd0679b3105331d909ea336b2d-628175af55dcfa07-00

albertospelta commented 1 year ago

Hi @Eiriksra! Unfortunately I'm not able to reproduce this issue. Are you able to share a sample PBIX model with some dummy data that shows this issue? If you prefer to share them privately, feel free to email me here alberto.spelta@sqlbi.com.

Eiriksra commented 1 year ago

Hi Alberto,

I appreciate your quick response, and sure - I'll attach my model here. It does in fact have demo data, as opposed to being a real company.

Just note that my error description was a bit inaccurate. This probably has nothing to do with Time Intelligence on a measure that's made out of two other measures added together. I think you'll find that Bravo crashes if asked to create time intelligence measures based on any measure in the model.

Regards,

Ragnar

On Tue, Jul 4, 2023 at 7:25 AM Alberto Spelta @.***> wrote:

Hi @Eiriksra https://github.com/Eiriksra! Unfortunately I'm not able to reproduce this issue. Are you able to share a sample PBIX model with some dummy data that shows this issue? If you prefer to share them privately, feel free to email me here @.***

— Reply to this email directly, view it on GitHub https://github.com/sql-bi/Bravo/issues/693#issuecomment-1619666143, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGNYWCUYDFGSZ2AQCR2ACJDXOPANBANCNFSM6AAAAAAZ2CU4IU . You are receiving this because you were mentioned.Message ID: @.***>

albertospelta commented 1 year ago

@Eiriksra looks like you replied via an e-mail. Unfortunately attachments are not included when replying by mail, so I can't view the PBIX model. Could you please reply on the original GitHub thread instead? Thank you!

Eiriksra commented 1 year ago

@albertospelta - I'm sorry but I'm a github newbie at best. Where do I attach a file on here? And can I be sure it goes to SQLBI only?

albertospelta commented 1 year ago

@Eiriksra if you want to share it privately please don't use GitHub but instead create a new email and send it to my SQLBI address alberto.spelta@sqlbi.com

albertospelta commented 1 year ago

Hi @Eiriksra, unfortunately I'm not able to reproduce the error using the PBIX model you sent me. Would you mind letting me know what kind of calendar template (e.g. Standard, Monthly,...) you used? Did you use the default configuration or did you set a custom configuration for the Interval/Dates/Holydays/TimeIntelligence params?

Eiriksra commented 1 year ago

Hi Alberto,

I'm very surprised to hear that. Did you try to create time intelligence measures based on an existing measure in the model and it simply worked? Bravo didn't crash on startup on this model (like it did in version 1.0.3) but for me at least, it always crashes when I ask it to create time intelligence measures based on e.g. "Net sales".

I'm pretty sure I used the standard calendar, but shouldn't Bravo be able to tell you that? No custom configuration for Interval/Dates/Holydays/TimeIntelligence params, although I'd love to implement Icelandic holidays in there, like I did for the SQLBI date template (v.1.18). I'm just not familiar enough with Github and Visual Studio to do it! On the off chance that you'd consider doing this for me, I'm happy to send you my changes for the above mentioned date template of yours:

-- IS = Iceland { "IS", 1, 1, 0, 0, 0, "Nýársdagur", 0, 100, 0 ,0 }, { "IS", 99, -3, 0, 0, 0, "Skírdagur", 0, 50, 0, 0 }, { "IS", 99, -2, 0, 0, 0, "Föstudagurinn langi", 0, 50,0 ,0 }, { "IS", 99, 1, 0, 0, 0, "Annar í páskum", 0, 50, 0, 0 }, { "IS", 99, 39, 0, 0, 0, "Uppstigningardagur", 0, 50,0 ,0 }, { "IS", 5, 1, 0, 0, 0, "Frídagur verkafólks", 0, 100, 0 ,0 }, { "IS", 8, 0, 1, 0, 0, "Frídagur verslunarmanna", 0, 100, 0 ,0 }, { "IS", 6, 17, 0, 0, 0, "Þjóðhátíðardagur Íslendinga", 0, 100, 0 ,0 }, { "IS", 12, 25, 0, 0, 0, "Jóladagur", 0, 100, 0 ,0 }, { "IS", 12, 26, 0, 0, 0, "Annar í jólum", 0, 100, 0 ,0 }, -- De facto holiday in Iceland although not specified by law { "IS", 12, 24, 0, 0, 0, "Aðfangadagur", 0, 50, 0 ,0 }, { "IS", 12, 31, 0, 0, 0, "Gamlársdagur", 0, 50, 0, 0 }, { "IS", 98, 0, 0, 0, 0, "Sumardagurinn fyrsti", 0, 50, 0 ,0 },

Regards,

Ragnar

On Wed, Jul 5, 2023 at 10:04 AM Alberto Spelta @.***> wrote:

Hi @Eiriksra https://github.com/Eiriksra, unfortunately I'm not able to reproduce the error using the PBIX model you sent me. Would you mind letting me know what kind of calendar template (e.g. Standard, Monthly,...) you used? Did you use the default configuration or did you set a custom configuration for the Interval/Dates/Holydays/TimeIntelligence params?

— Reply to this email directly, view it on GitHub https://github.com/sql-bi/Bravo/issues/693#issuecomment-1621444647, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGNYWCTU5YRERE3DYBWJRK3XOU34JANCNFSM6AAAAAAZ2CU4IU . You are receiving this because you were mentioned.Message ID: @.***>

albertospelta commented 1 year ago

@Eiriksra your changes for Icelandic holidays has been applied and released in version 1.0.5, thanks for your contribution!

albertospelta commented 1 year ago

Hi @Eiriksra, as I mentioned in my last email we were unable to reproduce the error on our end nor find the circular dependency error shown in the error message you shared - I just tested your PBIX and it worked as expected.

image

Could you tell us what are the exact steps to reproduce the error using the PBIX file you sent us?

Eiriksra commented 1 year ago

Hi Alberto,

I was very pleased with the news of Icelandic holidays being included, but when I updated Bravo and had a look, they were nowhere to be found. Any particular reason for this or was it just missed in the minor updates since then? Here's a screenshot of the version I'm running:

[image: image.png]

Regards,

Ragnar

On Mon, Aug 14, 2023 at 12:23 PM Alberto Spelta @.***> wrote:

@Eiriksra https://github.com/Eiriksra your changes for Icelandic holidays has been applied and released in version 1.0.5 https://github.com/sql-bi/Bravo/releases/tag/v1.0.5, thanks for your contribution!

— Reply to this email directly, view it on GitHub https://github.com/sql-bi/Bravo/issues/693#issuecomment-1677220491, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGNYWCTFYTYVIYSPFY2DLDTXVIKDFANCNFSM6AAAAAAZ2CU4IU . You are receiving this because you were mentioned.Message ID: @.***>

albertospelta commented 1 year ago

Hi @Eiriksra you are right, it is a bug in version 1.0.5. I have a fix checked in that will be part of the next release but in the meantime you can use the latest internal build - just change the update channel from stable to dev in the options\about panel and follow the link to download the installer.