search

sql-bi / DaxDateTemplate

Power BI template to create a Date table in DAX
MIT License
265 stars 76 forks source link

VAR FirstDayOfWeek #42

Closed ronkochanowski closed 3 years ago

ronkochanowski commented 3 years ago

VAR FirstDayOfWeek is set to 1, for Monday as the first day of the week. Yet, the measure 'Fiscal DatePreviousWeek' has the last day as Monday of the current week. Why would it not display Sunday? I'm not following the logic.

marcosqlbi commented 3 years ago

That column has this definition: "Same relative day in previous fiscal week" https://www.sqlbi.com/articles/reference-date-table-in-dax-and-power-bi/

Did you expect a different behavior?

ronkochanowski commented 3 years ago

I was looking for something different, and was attempting to use this measure to come up it it. Today is Friday, August 28. The same period a week ago would be Friday, August 21, correct? I dropped the measure ‘Fiscal DatePreviousWeek’ into a grid. Changed the filter ‘First Value of’ To ‘Last Value of’ and the date that displayed was August 24, this past Monday. It seemed to me that the last value of the previous week would be Sunday, since I have the VAR FirstDayOfWeek set to 1 in the configuration.

marcosqlbi commented 3 years ago

"Fiscal DatePreviousWeek" is a column, you dropped a "measure" with the same name. I assume you are referencing the column, otherwise please clarify. I just double-checked and the value of "Fiscal DatePreviousWeek" for Aug 28 is Aug21, as expected. But I don't understand what you mean with "Changed the filter ‘First Value of’ To ‘Last Value of’ " - can you clarify exactly how you are creating the report? Can you share the DAX query captured with Performance Analyzer?

ronkochanowski commented 3 years ago

Thank you Marco, In the process of standardizing our Date tables, this particular report got messed up. One of the measures that we'd defined was not producing correct results, but is now corrected. My apologies for any hardship.

On Sat, Aug 29, 2020 at 12:54 AM Marco Russo notifications@github.com wrote:

"Fiscal DatePreviousWeek" is a column, you dropped a "measure" with the same name. I assume you are referencing the column, otherwise please clarify. I just double-checked and the value of "Fiscal DatePreviousWeek" for Aug 28 is Aug21, as expected. But I don't understand what you mean with "Changed the filter ‘First Value of’ To ‘Last Value of’ " - can you clarify exactly how you are creating the report? Can you share the DAX query captured with Performance Analyzer?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sql-bi/DaxDateTemplate/issues/42#issuecomment-683236826, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHLTNWGDORXRBIA5EWJUNDSDCCWTANCNFSM4QOMNEVA .

marcosqlbi commented 3 years ago

No problems - thanks for closing the loop, I can close the issue now! 👍