search

sql-formatter-org / sql-formatter

A whitespace formatter for different query languages
https://sql-formatter-org.github.io/sql-formatter/
MIT License
2.37k stars 405 forks source link

Fixes yarn.lock for yarn check verification #799

Closed tonycoco closed 1 week ago

tonycoco commented 2 weeks ago

yarn.lock failed to pass yarn check. This fixes it without direct dependency modifications.

codesandbox-ci[bot] commented 2 weeks ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

nene commented 1 week ago

Thanks for the PR.

Would you care to explain how did you achieve this? That is, I guess you didn't go through all the warnings one-by-one to resolve them, but did it in some automated way.

I'm also not sure what you mean by "without dependency modifications". Your PR definitely contains lots of changes to the dependencies listed in yarn.lock file.

tonycoco commented 1 week ago

Ahh yes, sorry, meant to say no direct dependencies changed. Underlying deps that were removed, outdated, or had critical fixes were changed so that yarn check works again. I did it by re-generating a yarn.lock file. I noticed the errors since a few projects I work on used sql-formatter as a pre-commit hook.

nene commented 1 week ago

Thanks for the explanation. Much appreciated!

tonycoco commented 1 week ago

@nene can you bump the version for this change? pre-commit needs a rev to apply the fix here

nene commented 1 week ago

No problem. Done.