sql-js / react-sqljs-demo

A demonstration showing how to use sql.js with create-react-app
https://react-sqljs-demo.ophir.dev/
MIT License
110 stars 33 forks source link

Load test.db sqlite database demo file #3

Open eSlider opened 4 years ago

eSlider commented 4 years ago

As discussed in previous PR I improved live-demo by add database file load example to become abilities run SQL queries on it.

Changes

eSlider commented 4 years ago

Nice !

Two little things :

  • it would be good if the example database would have a little more data, to let people play around with joins and filters. You can use for instance the Dallas Police Officer-Involved Shootings from this page: http://2016.padjo.org/tutorials/sqlite-data-starterpacks/
  • The default query should be executed immediately once the database has been loaded.

It's can be done. But about the hype: I prefer to use more neutral demo file. Do you have better option?

lovasoa commented 4 years ago

It's can be done. But about the hype: I prefer to use more neutral demo file. Do you have better option?

The Dallas Police Officer-Involved Shootings is great. It is small enough to load quickly, is not copyrighted, and contains interesting public data, with several tables that can be joined. If you find or create another database that meets these criteria and want to include it instead, go ahead; but I don't think the Dallas PD data has any reason for being controversial.