search

sql-machine-learning / elasticdl

Kubernetes-native Deep Learning Framework
https://elasticdl.org
MIT License
731 stars 113 forks source link

Can we remove the parameter server implementation with Python #2196

Open Yancey1989 opened 4 years ago

Yancey1989 commented 4 years ago

There is two entry point of the parameter server instance, the one is Python /elasticdl/python/ps, another one is /elasticdl/go/cmd/elasticdl_ps.

It seems the Python code is useless, can we remove it from this repo? c.f. https://github.com/sql-machine-learning/elasticdl/blob/6b1a1b2cd59d07bba642ff648afc0ad42160ee16/elasticdl/python/master/master.py#L414

QiJune commented 4 years ago

Yes, we could remove the parameter server implementation with Python.

The parameter server implementation with Go has been used in production already. It's safe to remove Python codes.