Move grpc_utils.py and log_utils.py to util folder in elasticai_api.

sql-machine-learning / elasticdl

Kubernetes-native Deep Learning Framework

https://elasticdl.org

MIT License

733 stars 113 forks source link

Move grpc_utils.py and log_utils.py to util folder in elasticai_api. #2443

Closed brightcoder01 closed 3 years ago

workingloong commented 3 years ago

Can elasticai_api and elasticdl have their log_util and grpc_util separately? It can decrease dependency of elasticdl.

brightcoder01 commented 3 years ago

Can elasticai_api and elasticdl have their log_util and grpc_util separately? It can decrease dependency of elasticdl.

The dependency on elasticai_api is necessary for elasticdl because the proto messages and services about Dynamic Sharding is required by these two packages. I would prefer keeping only one copy of the common modules for these two packages in elasticai_api in order to avoid duplicated code.