Performance issue in the program

sql-machine-learning / elasticdl

Kubernetes-native Deep Learning Framework

https://elasticdl.org

MIT License

733 stars 113 forks source link

Performance issue in the program #2521

Closed DLPerf closed 3 years ago

DLPerf commented 3 years ago

Hello, I found a performance issue in the definition of RecordIODataReaderTest, elasticdl/blob/develop/elasticdl/python/tests/data_reader_test.py, tf.io.FixedLenFeature in the line 70 and 71 will be called in the program execution, resulting in reduced efficiency. I think it should be created before the loop in RecordIODataReaderTest.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

workingloong commented 3 years ago

You can feel free make a PR to fix it.