sql-machine-learning / sql-machine-learning.github.io

21 stars 12 forks source link

Remove useless submodules #76

Closed weiguoz closed 5 years ago

weiguoz commented 5 years ago

Remove gohive, gomaxcompute, pysqlflow from the document

tonyyang-svail commented 5 years ago

@typhoonzero @weiguoz The gohive/maxcompute submodel contains index.html that is necessary for Go vanity import.

https://github.com/sql-machine-learning/gohive/blob/63a00321b51afea0f117f3fc90303e5b97eaa7f9/index.html#L1-L13

Our SQLFlow CI is failed due to this removal. https://travis-ci.com/sql-machine-learning/sqlflow/builds/129164410

package sqlflow.org/gohive: unrecognized import path "sqlflow.org/gohive" (parse https://sqlflow.org/gohive?go-get=1: no go-import meta tags ())
package sqlflow.org/gomaxcompute: unrecognized import path "sqlflow.org/gomaxcompute" (parse https://sqlflow.org/gomaxcompute?go-get=1: no go-import meta tags ())
The command '/bin/sh -c bash ${GOPATH}/src/sqlflow.org/sqlflow/scripts/build_docker_image.sh &&     mkdir -p /workspace &&     bash ${GOPATH}/src/sqlflow.org/sqlflow/scripts/convert_markdown_into_ipynb.sh &&     rm -rf ${GOPATH}/src && rm -rf ${GOPATH}/bin' returned a non-zero code: 1