search

sql-machine-learning / sqlflow

Brings SQL and AI together.
https://sqlflow.org
Apache License 2.0
5.11k stars 703 forks source link

Make experimental codegen read model from model zoo #3013

Closed sneaxiy closed 4 years ago

sneaxiy commented 4 years ago

Fix https://github.com/sql-machine-learning/sqlflow/issues/3011 .

Partially fix https://github.com/sql-machine-learning/sqlflow/issues/3005 .

codecov-io commented 4 years ago

Codecov Report

Merging #3013 into develop will decrease coverage by 0.17%. The diff coverage is 26.54%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3013      +/-   ##
===========================================
- Coverage    50.57%   50.39%   -0.18%     
===========================================
  Files          247      248       +1     
  Lines        17665    17756      +91     
===========================================
+ Hits          8934     8949      +15     
- Misses        8050     8123      +73     
- Partials       681      684       +3
Impacted Files Coverage Δ
go/codegen/experimental/codegen_step.go 23.46% <0.00%> (-4.54%) :arrow_down:
go/modelzooserver/modelzooserver.go 52.69% <34.00%> (-3.36%) :arrow_down:
python/runtime/model/modelzoo.py 35.29% <35.29%> (ø)
python/runtime/model/model.py 69.90% <46.66%> (-5.10%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be41f4a...31d015f. Read the comment docs.