search

sql-machine-learning / sqlflow

Brings SQL and AI together.
https://sqlflow.org
Apache License 2.0
5.11k stars 703 forks source link

Make CI run on both legacy codegen and experimental codegen #3016

Closed sneaxiy closed 4 years ago

sneaxiy commented 4 years ago

Also, fix some errors on Hive CI.

2020-10-12T13:34:28.0638028Z     --- FAIL: TestEnd2EndHive/caseTrainSQL (47.71s)
2020-10-12T13:34:28.0639440Z         testing.go:165: 
2020-10-12T13:34:28.0641323Z                Error Trace:    testing.go:165
2020-10-12T13:34:28.0644278Z                                            e2e_common_cases.go:395
2020-10-12T13:34:28.0646410Z                Error:          unsupported type comparison type.googleapis.com/google.protobuf.Int32Value int64
2020-10-12T13:34:28.0648765Z                Test:           TestEnd2EndHive/caseTrainSQL
2020-10-12T13:34:28.0650927Z         testing.go:165: 
2020-10-12T13:34:28.0652283Z                Error Trace:    testing.go:165
2020-10-12T13:34:28.0653437Z                                            e2e_common_cases.go:395
2020-10-12T13:34:28.0655322Z                Error:          unsupported type comparison type.googleapis.com/google.protobuf.Int32Value int64
2020-10-12T13:34:28.0657517Z                Test:           TestEnd2EndHive/caseTrainSQL
2020-10-12T13:34:28.0658744Z         testing.go:165: 
2020-10-12T13:34:28.0660689Z                Error Trace:    testing.go:165
2020-10-12T13:34:28.0661827Z                                            e2e_common_cases.go:395
2020-10-12T13:34:28.0664259Z                Error:          unsupported type comparison type.googleapis.com/google.protobuf.Int32Value int64
2020-10-12T13:34:28.0666540Z                Test:           TestEnd2EndHive/caseTrainSQL
2020-10-12T13:34:28.0667935Z         testing.go:165: 
2020-10-12T13:34:28.0669059Z                Error Trace:    testing.go:165
2020-10-12T13:34:28.0670226Z                                            e2e_common_cases.go:395
2020-10-12T13:34:28.0671996Z                Error:          unsupported type comparison type.googleapis.com/google.protobuf.Int32Value int64
2020-10-12T13:34:28.0673829Z                Test:           TestEnd2EndHive/caseTrainSQL
2020-10-12T13:34:28.0674978Z         testing.go:165: 
2020-10-12T13:34:28.0675929Z                Error Trace:    testing.go:165
2020-10-12T13:34:28.0677068Z                                            e2e_common_cases.go:395
2020-10-12T13:34:28.0678801Z                Error:          unsupported type comparison type.googleapis.com/google.protobuf.Int32Value int64
2020-10-12T13:34:28.0680776Z                Test:           TestEnd2EndHive/caseTrainSQL
codecov-io commented 4 years ago

Codecov Report

Merging #3016 into develop will increase coverage by 0.07%. The diff coverage is 62.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3016      +/-   ##
===========================================
+ Coverage    50.35%   50.42%   +0.07%     
===========================================
  Files          248      248              
  Lines        17797    17829      +32     
===========================================
+ Hits          8962     8991      +29     
+ Misses        8149     8148       -1     
- Partials       686      690       +4
Impacted Files Coverage Δ
go/cmd/sqlflowserver/testing.go 66.19% <62.00%> (+6.07%) :arrow_up:
go/modelzooserver/modelzooserver.go 51.15% <0.00%> (-3.60%) :arrow_down:
go/sql/executor_ir.go 38.77% <0.00%> (+6.12%) :arrow_up:
go/cmd/step/step.go 41.66% <0.00%> (+16.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67622e4...9bab110. Read the comment docs.