drop_index does not support postgresql_concurrently=True

sqlalchemy-bot / test_alembic_1

0 stars 0 forks source link

Closed sqlalchemy-bot closed 7 years ago

sqlalchemy-bot commented 7 years ago

Migrated issue, originally created by Alex Plugaru (sasha)

Seems create_index supports postgresql_concurrently=True, but not drop_index.

Related to #277

sqlalchemy-bot commented 7 years ago

Michael Bayer (zzzeek) wrote:

i don't know that op.create_index() ever explicitly had any change for postgresql_concurrently, it just accepts kwargs whereas drop_index doesn't.

sqlalchemy-bot commented 7 years ago

Alex Plugaru (sasha) wrote:

I'd love to send a small PR for this, but I have no idea how to do it. How do you fork a repo here?

sqlalchemy-bot commented 7 years ago

Michael Bayer (zzzeek) wrote:

it would need to support the option for both create_index and drop_index and have tests in tests/test_postgresql.py.

click the plus sign on far left and click "Fork"

sqlalchemy-bot commented 7 years ago

Michael Bayer (zzzeek) wrote:

i have it up here: https://gerrit.sqlalchemy.org/465

sqlalchemy-bot commented 7 years ago

Michael Bayer (zzzeek) wrote:

Add support for kw to DROP INDEX, test postgresql_concurrently

Change-Id: I89c98401d3e1f1252041b622e045c6dc85fa59a1 Fixes: #424

→ 101136605150

sqlalchemy-bot commented 7 years ago

Michael Bayer (zzzeek) wrote:

Add support for kw to DROP INDEX, test postgresql_concurrently

Change-Id: I89c98401d3e1f1252041b622e045c6dc85fa59a1 Fixes: #424

→ a893eb97a90d

sqlalchemy-bot commented 7 years ago

Alex Plugaru (sasha) wrote:

I tested locally just now and can confirm that it works.

sqlalchemy-bot commented 7 years ago

Alex Plugaru (sasha) wrote:

Thank you!

sqlalchemy-bot commented 7 years ago

Changes by Michael Bayer (zzzeek):