implement detection of collation changes on a column

sqlalchemy / alembic

A database migrations tool for SQLAlchemy.

MIT License

2.74k stars 239 forks source link

implement detection of collation changes on a column #1041

Open jekel opened 2 years ago

jekel commented 2 years ago

I have found the same problem as described in #475 , when you change for example String field with adding collation parameter to it - alembic does not see this change on autogenerate

Versions.

OS: MS Windows 10
Python: 3.9.10
Database: PostgreSQL 12
alembic 1.7.7
SQLAlchemy 1.4.35

zzzeek commented 2 years ago

hi -

please reopen #475 with clear reproducing examples. modify my model at https://github.com/sqlalchemy/alembic/issues/475#issuecomment-441887543 to show a model that fails.

zzzeek commented 2 years ago

oh we also dont compare "collation" on an existing coulmn at all right now, you will need to add migrations manually. will keep this open as a use case.

faizanalhassan commented 4 days ago

Hi @zzzeek , any updates on this issue?