sqlalchemy / alembic

A database migrations tool for SQLAlchemy.
MIT License
2.76k stars 241 forks source link

Implement ExecuteSQLOp.to_diff_tuple, fixes #1335 #1336

Closed BayerSe closed 11 months ago

BayerSe commented 11 months ago

Description

This implements ExecuteSQLOp.to_diff_tuple, which is necessary when custom SQL statements are added to the diff stream via some hook.

Checklist

This pull request is:

Have a nice day!

sqla-tester commented 11 months ago

New Gerrit review created for change 4ec6638bc28d048da5745e854e584fb3581af9c2: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4914

zzzeek commented 11 months ago

great, looks like you filled out the whole format/changelog, thanks

zzzeek commented 11 months ago

this is currently failing CI for a few small reasons - are you able to check out the failures for SQLA 1.3 and pep8 over at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4914 on the left side?

BayerSe commented 11 months ago

@zzzeek should be fixed now, can you please trigger another CI run?

sqla-tester commented 11 months ago

Patchset c5e217e99d0fae87ccc89fc57c71e1c07c57ea97 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4914

sqla-tester commented 11 months ago

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/4914 has been merged. Congratulations! :)