Fix constraint_name type in create_primary_key

kasium commented 3 months ago

The constraint name in create_primary_key should be optional, but for batch operations is is required according to the type annotations

Changed the type annotation to Optional[str]

This pull request is:

[ ] A documentation / typographical error fix
- Good to go, no issue or tests are needed
[X] A short code fix
- please include the issue number, and create an issue if none exists, which must include a complete example of the issue. one line code fixes without an issue and demonstration will not be accepted.
- Please include: Fixes: #<issue number> in the commit message
- please include tests. one line code fixes without tests will not be accepted.
[ ] A new feature implementation
- please include the issue number, and create an issue if none exists, which must include a complete example of how the feature would look.
- Please include: Fixes: #<issue number> in the commit message
- please include tests.

Have a nice day!

CaselIT commented 3 months ago

Indeed, thanks for looking.

I'll update the stubs and commit

sqla-tester commented 3 months ago

New Gerrit review created for change 8afb2bf3fbddc1b04a9da7c5cc5553dea2c1c593: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5243

kasium commented 3 months ago

Thanks!

sqla-tester commented 2 months ago

sqlalchemy / alembic