search

sqlalchemy / alembic

A database migrations tool for SQLAlchemy.
MIT License
2.76k stars 241 forks source link

Improve server_default / existing_server_default typing #1468

Open CaselIT opened 5 months ago

CaselIT commented 5 months ago

The public typing have an incorrect type for it. Use the correct one defined here:

https://github.com/sqlalchemy/alembic/blob/ade17cfd8dd1a12d6babceb24126511ddab1085a/alembic/ddl/base.py#L39

Olegt0rr commented 1 month ago

Wonder about default value False.

https://github.com/sqlalchemy/alembic/blob/9d6e212b77c8ce5ea1164b6d67f2ba491beba413/alembic/operations/ops.py#L1836-L1838

and some other places - the same.

Changing it to None failed some tests with mssql generated sql 0_o

CaselIT commented 1 month ago

That's not the issue. False there has a particular meaning