Enhance version_path_separator behaviour by adding a newline option

pristupa commented 4 months ago

version_path_separator now consists a new option "newline" which allows you to specify multiple version locations across multiple lines like this:

version_locations =
  /foo/versions
  /bar/versions
  /baz/versions

version_path_separator = newline

This pull request is:

[ ] A documentation / typographical error fix
- Good to go, no issue or tests are needed
[ ] A short code fix
- please include the issue number, and create an issue if none exists, which must include a complete example of the issue. one line code fixes without an issue and demonstration will not be accepted.
- Please include: Fixes: #<issue number> in the commit message
- please include tests. one line code fixes without tests will not be accepted.
[x] A new feature implementation
- please include the issue number, and create an issue if none exists, which must include a complete example of how the feature would look.
- Please include: Fixes: #<issue number> in the commit message
- please include tests.

Have a nice day!

CaselIT commented 3 months ago

Thanks, looks ok! Will run the pipeline

CaselIT commented 3 months ago

That error seems to be caused by the mypy update. Will fix elsewhere

sqla-tester commented 3 months ago

New Gerrit review created for change 00a1a043042ff70c69b69b727e5d55c34cd9cfd3: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5417

sqla-tester commented 3 months ago

Patchset a4d2a1e22cda949da5689ecf8a2a8e926437df05 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5417

pristupa commented 3 months ago

@CaselIT should I fix those issues from the Gerrit review?

CaselIT commented 3 months ago

if you run black it should fix them for you

pristupa commented 3 months ago

I've just run it with "tox e -- black ." Hopefully it's what was assumed. Not sure it's nice formatted now though.

sqla-tester commented 3 months ago

Patchset b1465ec5d8fd421b52f1e761f6a4c3648c4a2475 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5417

CaselIT commented 3 months ago

pristupa commented 3 months ago

oh thank you, didn't notice that one added an individual changelog

sqla-tester commented 3 months ago

Patchset 6155da71472fa2727beabd0aeaec1bdc07378b1b added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5417

sqla-tester commented 3 months ago

Michael Bayer (zzzeek) wrote:

ok we need a changelog note here, do we have any tests for these version path seps?

sqla-tester commented 3 months ago

Federico Caselli (CaselIT) wrote:

it has both. maybe you looked an old version?

sqla-tester commented 3 months ago

Michael Bayer (zzzeek) wrote:

gerrit must have bounced me into an older version

sqla-tester commented 3 months ago

sqlalchemy / alembic