sqlalchemy / alembic

A database migrations tool for SQLAlchemy.
MIT License
2.89k stars 249 forks source link

Improve write_pyi usage #1525

Closed agriffin-grow closed 2 weeks ago

agriffin-grow commented 2 months ago

Fixes #1524

Description

Due to some problems when running write_pyi, this includes the following changes:

  1. move the sys.path.append up before alembic is imported - this is using global imports otherwise
  2. use tox to run write_pyi in order to avoid globally installed dependencies

Checklist

This pull request is:

Have a nice day!

sqla-tester commented 2 weeks ago

New Gerrit review created for change 679ea5c67ebbf5062891d50dabf6323cf5348d82: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5586

sqla-tester commented 2 weeks ago

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5586 has been merged. Congratulations! :)