search

sqlalchemy / mako

Mako Templates for Python
https://www.makotemplates.org
MIT License
364 stars 62 forks source link

Use `pre-commit` as linter & Checker ✨ #345

Closed yezz123 closed 2 years ago

yezz123 commented 3 years ago

Based on this issue https://github.com/sqlalchemy/mako/issues/344, I was thinking about why not use .pre-commit as a linter and checker.

Easy way to check code and fix any issue related to code style and code linting, about the rules I use only simple and most used rules for linting, SQLalchemy's team is free to change the rules or use another one for linting.

Note: This is just a simple enhancement to repository structure.

CaselIT commented 3 years ago

Thanks for the work. I've left a review.

It's probably best to wait for @zzzeek on this also so a single set of changes can be done

bourke commented 2 years ago

Thanks for the contribution. As @CaselIT and @jvanasco mentioned above, this PR gives pre-commit more responsibility in our tooling than we're comfortable with — especially considering that we'd prefer to keep the configurations as consistent as we can across the sqlalchemy organisation. @zzzeek suggested that the configuration for dogpile.cache would be a good reference point.

bourke commented 2 years ago

Hey there -- closing this for now. Let me know if you want to take it back up.