search

sqlalchemy / mako

Mako Templates for Python
https://www.makotemplates.org
MIT License
353 stars 60 forks source link

optimize some code paths #361

Closed atetubou closed 2 years ago

atetubou commented 2 years ago

This optimizes mako template engine by reducing the number of regex compiles and replace some regex usage with simpler string utility function.

This shows around 10% performance improvement in our use case (https://crbug.com/1214033#c32).

zzzeek commented 2 years ago

OK can you run "black" on the code changes so it passes pep8, thanks!

sqla-tester commented 2 years ago

New Gerrit review created for change 6c1b2eea9f0004538c4dd0ea24a25db82884b3c3: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/3959

atetubou commented 2 years ago

I applied black, could you run check again?

sqla-tester commented 2 years ago

Patchset bcdee5ccf57100490aa0e48baeda6f15b584ab32 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/3959

sqla-tester commented 2 years ago

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/3959 has been merged. Congratulations! :)

atetubou commented 2 years ago

Thank you for merge and quick release!