Closed gagern closed 2 years ago
New Gerrit review created for change 6b5ff13dd5346f3472ac93f3af0a9da172ae1c5e: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/4043
it looks like 33 additional tests are running now, does that match your observations?
if you want to take a look at https://jenkins.sqlalchemy.org/job/mako_gerrit/pyv=py311/109/testReport/ that's a run, fortunately the skipped tests seem to be passing.
it looks like 33 additional tests are running now, does that match your observations?
Yes, 33 additional tests is in line with what I found locally and indicated in both the commit description and the pull request description.
it looks like 33 additional tests are running now, does that match your observations?
Yes, 33 additional tests is in line with what I found locally and indicated in both the commit description and the pull request description.
oh, sorry, my eyes are old and miss things frequently
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/4043 has been merged. Congratulations! :)
thanks for this contribution!
https://github.com/sqlalchemy/mako/commit/7e52b60b7dac75a3c7177e69244123c0dad9e9d9 changed tests from
unittest.TestCase
to pytest collection. But since then only classes ending in the wordTest
were considered to be tests; classes starting inTest
were not. This disabled some existing tests, and while renaming these would be a viable way to restore coverage, extending the list of test class names avoids accidentally missing similar classes in the future.The loop test classes make use of the
setUp
method, so in their current form they need to inherit fromunittest
again. Changing to pytest fixtures would be a possible future modification.This commit adds 33 tests that had been missing before:
test_loop.py
TestTemplateAPI
fromtest_template.py
TestTGPlugin
fromtest_tgplugin.py