search

sqlalchemy / mako

Mako Templates for Python
https://www.makotemplates.org
MIT License
353 stars 60 forks source link

Encode output inside mako cmd and write as binary #377

Closed ni-balexand closed 11 months ago

ni-balexand commented 1 year ago

This change is a proposed fix for #376

sqla-tester commented 1 year ago

Mike Bayer has proposed a fix for this issue in the main branch:

switch to textmode in all cases https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/4450

zzzeek commented 11 months ago

I dont understand this PR or my comments about "fix this on the read side". If this is for #376 why isn't it just the fix I proposed at https://github.com/sqlalchemy/mako/issues/376#issuecomment-1432083590 ? Changing Mako to not read from binary mode or whatever can be something else.

can we make a PR that fixes #376 in the most simple way possible, thanks.

zzzeek commented 11 months ago

looks like I requested that here at https://github.com/sqlalchemy/mako/pull/377#pullrequestreview-1300411533 already, so this PR is stalled. We can reopen if someone has time to work on this or make a new PR against #376.