search

sqlalchemy / mako

Mako Templates for Python
https://www.makotemplates.org
MIT License
353 stars 60 forks source link

Passing keyword only args as positional should fail. #406

Open ianjosephwilson opened 2 months ago

ianjosephwilson commented 2 months ago

Issue

405

This is a backwards incompatible change because code that was "working" will now throw an exception.

Historically related

836e5f97e84088cd3104cb3a30bf02e8a6c0a9a5

sqla-tester commented 2 months ago

New Gerrit review created for change c8acb9a54237b367f514c58e913bb0f5aac14855: https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/5337

zzzeek commented 2 months ago

tricky, because extremely trivial, yet the backwards compat for a very slow moving project like Mako implies we'd need a major release.

waht if we just keep this as an unusual idiosyncratic behavior and just add a test that it passes?

ianjosephwilson commented 2 months ago

That's fine. Someone just asked about on stackoverflow. Should there be a note in the Using defs part of the documentation or just leave the test as the documentation?

zzzeek commented 2 months ago

I think adding a doc note is fine, indicating there's a bit of legacy behavior here to be aware of, in addition to a test that notes it's related to issue #405