search

sqlalchemyorg / zimports

Python import rewriter
MIT License
75 stars 6 forks source link

vendor lookup_entry_point to avoid pgk_resources deprecation warnings #42

Closed CaselIT closed 1 year ago

CaselIT commented 1 year ago

fixes the error that happens when doing python -Werror -c 'import zimport's: DeprecationWarning: pkg_resources is deprecated as an API

zzzeek commented 1 year ago

does this work around an issue in flake8_import_order? was a bug reported to them ?

CaselIT commented 1 year ago

does this work around an issue in flake8_import_order

by not importing the module that raises the deprecation warning

was a bug reported to them ?

yes, but so far crickets https://github.com/PyCQA/flake8-import-order/issues/201

zzzeek commented 1 year ago

alrighty, yes make sure a link to that github issue is in a "references:" line in the commit here, so that it's linked to their issue. seems to have only been two days over there but it looks like not much activity on this project in general

CaselIT commented 1 year ago

anything required to merge and release?

zzzeek commented 1 year ago

ah we have a test suite here and it worked. well great, nope we're done thanks

CaselIT commented 1 year ago

I've released