sqlalchemyorg / zzzeeksphinx

zzzeek's sphinx layout (used by SQLAlchemy, Mako templaets)
Other
4 stars 4 forks source link

[fix] improve link readability #15

Closed drc0 closed 1 year ago

drc0 commented 1 year ago

the link color contrast is not enough to be distinguished improve the readability with underlined links for the docs main body content

CaselIT commented 1 year ago

Not sure I would trust that tool too much. This gets a pass, but it's basically invisible https://webaim.org/resources/linkcontrastchecker/?fcolor=212529&bcolor=FFFFFF&lcolor=757575 image

regardless that red looks a but much, but I'm no designer, so it's fine by me

drc0 commented 1 year ago

ok thanks for the feedback! I had to admin I'm (almost) red green color blind so slim red text with surrounding green accents are a lot confusing to me, but I have to admin #E00000 is at least an improvement from what is now, should we confirm that color?

zzzeek commented 1 year ago

ok thanks for the feedback! I had to admin I'm (almost) red green color blind so slim red text with surrounding green accents are a lot confusing to me, but I have to admin #E00000 is at least an improvement from what is now, should we confirm that color?

OK well is it enough? I used the tool's recommendations assuming they come from some place of authority , we can also change the font spacing which might be a little tight

zzzeek commented 1 year ago

-

Not sure I would trust that tool too much. This gets a pass, but it's basically invisible https://webaim.org/resources/linkcontrastchecker/?fcolor=212529&bcolor=FFFFFF&lcolor=757575 image

regardless that red looks a but much, but I'm no designer, so it's fine by me

dunno this is w3 stuff, comes straight from the top https://www.w3.org/TR/WCAG20/

zzzeek commented 1 year ago

i would gather there's a tool that would just look at our whole site and find issues

of course, "we're only in English" is one of our biggest issues....

CaselIT commented 1 year ago

of course, "we're only in English" is one of our biggest issues....

Well gpts should help a lot here, since they seem quite good at translating text

drc0 commented 1 year ago

superseded by #17