search

sqlanywhere / node-sqlanywhere

SAP SQL Anywhere Database Client for Node
Apache License 2.0
38 stars 36 forks source link

Node 12.x support #35

Open pkeuter opened 4 years ago

pkeuter commented 4 years ago

Thanks for this very useful library! Since October 21, Node v12 has gone into LTS. Unfortunately, on NPM there are only precompiled binaries for node-sqlanywhere up to v10.

I've tried to build with node 12, but there are quite some differences (like Handle being gone and using context on all conversions). So I can imagine it will take some time to migrate (at least it would for me).

In the mean time I'm trying to migrate to Node v12 myself, but I'm not really sure what the implications are of my changes so if @gperrow-SAP would have a look that would be amazing!

gperrow-SAP commented 4 years ago

I don't work on the node driver anymore but I know the team that does monitors issues here. A node v12 upgrade is at least on the roadmap but I can't speak to scheduling.

pkeuter commented 4 years ago

I've tried to make this work in #36 but I'm not sure if I've done everything correctly. Maybe someone can have a look and give some feedback.

I changed the version to 2.0 because I don't think it will be very backwards-compatible.

pkeuter commented 4 years ago

By the way thanks @gperrow-SAP for the heads up.

imankurpatel000 commented 4 years ago

@gperrow-SAP Is there any update on this? I think @pkeuter has already made a pull request and made changes. Can you please look at it and get it committed asap.

imankurpatel000 commented 4 years ago

@DanCummins-SAP @gperrow-SAP Any update on this? Is there anything else that we can do to help?