search

sqlcipher / android-database-sqlcipher

Android SQLite API based on SQLCipher
https://www.zetetic.net/sqlcipher/sqlcipher-for-android/
Other
2.73k stars 564 forks source link

update androidx.sqlite/sqlite -> 2.1.0 #501

Closed brodybits closed 1 year ago

brodybits commented 4 years ago

UPDATED January 2023:

I think it would be ideal to update this androidx.sqlite/sqlite to 2.2.0, but it looks to me like this would incur a requirement for Android SDK 31. I am not sure if we are ready for this kind of breaking change yet.

This is just a suggestion to use the latest version of androidx.sqlite from https://mvnrepository.com/artifact/androidx.sqlite/sqlite. This worked for me when using my custom build in an Apache Cordova test project. I hope I will have a chance to test an AAR with the test suite in sqlcipher-android-tests in the near future, no promises due to some urgent project work. I am raising this as a draft PR for now.

commonsguy commented 4 years ago

I think we need to make some modifications for this to work. If nothing else, they added useNoBackupDirectory to SupportSQLiteOpenHelper.Configuration. We probably need to honor that.

piotr-pawlowski commented 4 years ago

Please consider update androidx.sqllite to 2.1.0.

Here is an example of implementation for useNoBackupDirectory: https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/sqlite/sqlite-framework/src/main/java/androidx/sqlite/db/framework/FrameworkSQLiteOpenHelper.java#61

developernotes commented 4 years ago

Hello @piotr-pawlowski

We are just finishing efforts on the next public SQLCipher release. Unfortunately, an update to the androidx.sqlite dependency will need to occur in a follow-up release. We have added it to our backlog. Thanks!

epicstar commented 3 years ago

Hello. I noticed that this was closed. Is androidx.sqlite updated to 2.1.0?

brodybits commented 3 years ago

Nope, just reopened.

brodybits commented 1 year ago

I hope we can consider getting this one updated to 2.1.0 or 2.2.0. I think 2.2.0 would be ideal but it seems to require Android SDK 31 update.

developernotes commented 1 year ago

Hi @brodybits,

This is merged into master, thanks!