search

sqlcipher / android-database-sqlcipher

Android SQLite API based on SQLCipher
https://www.zetetic.net/sqlcipher/sqlcipher-for-android/
Other
2.73k stars 564 forks source link

update com.android.tools.build/gradle -> 7.3.1 #613

Closed brodybits closed 1 year ago

brodybits commented 1 year ago

ref:

developernotes commented 1 year ago

Hi @brodybits,

Thank you again for reaching out with the recent series of pull requests related to SQLCipher for Android and the corresponding test suite, we do appreciate your continued interest in the project. We are in the process of reviewing all of your requests.

In case you may have missed it, SQLCipher for Android (i.e., android-database-sqlcipher) will be replaced, currently being termed our legacy edition of the library. The new version (i.e., sqlcipher-android) was announced here which provides improved concurrency support along with a revised Java API. We made the first public beta release available during our 4.5.2 release, however, that has been superseded with our most recent update of 4.5.3.

Because there are such a large number of users on android-database-sqlcipher, there will be a longer transition period where we continue to maintain both libraries. We will review your changes both in the context of android-database-sqlcipher, and also with regard to sqlcipher-android as we would prefer to not introduce a divergence in support.

Given a large number of recent pull requests, in the future would you consider opening a GitHub Issue to discuss the series of changes you have in mind first? We think this may be helpful to have a dialog regarding the overall scope of changes first, and may minimize the changes/pull requests necessary.

Thank you again for your support of the SQLCipher projects, we hope you're having a Happy New Year!

brodybits commented 1 year ago

Thanks and you too!

My apologies and apologies for the obviously bad timing. Next time I will open a discussion before proposing too many changes.

I need to update my own fork for a new customer and was hoping to keep the divergence to a minimum.

In general I would favor using updated dependencies and toolchains as much as possible.

OTOH I do totally understand the need to avoid potentially breaking changes as long as needed.

I did take a quick look into the new sqlcipher-android. It does look to me like there are some outdated dependencies and Gradle wrapper(s) there as well. I would love to give this a shot in sqlcipher-android someday, time permitting, seems to be mostly a mechanical process now.

A few more things I can think of:

developernotes commented 1 year ago

Hi @brodybits,

Thanks for this, we've merged this in!