search

sqlcipher / sqlcipher-android-tests

A collection of tests that can be run on an emulator or device to verify SQLCipher for Android.
Other
94 stars 65 forks source link

First test of cursor getType() #1

Closed brodycj closed 11 years ago

brodycj commented 11 years ago

I made pull request 80 on android-database-sqlite to get the type of retrieved data. Here is a small test to verify the change is working.

developernotes commented 11 years ago

Hi brodyspark,

Thanks for your interest in the SQLCipher for Android test suite. The test you modified is testing a specific scenario, one that is different than checking the column type from a Cursor. We would welcome an additional test, however we would like to to exist on its own as an individual test. Could you extract your test from this change and add it to the test suite runner? Thanks!

developernotes commented 11 years ago

Hi brodyspark,

This pull request appears to be targeting a newer version of the Cursor, specifically the call to getType(...) which was added at API level 11. Do you have a pull request that adds the getType(...) function support to the SQLiteCursor class within the SQLCipher for Android project?

brodycj commented 11 years ago

"I made pull request 80 on android-database-sqlite" - https://github.com/sqlcipher/android-database-sqlcipher/pull/80

Also: I needed the changes in https://github.com/sqlcipher/android-database-sqlcipher/pull/79 to build on OSX, if I installed Android SDK & NDK using Homebrew.

developernotes commented 11 years ago

Hi brodyspark,

Thanks - I am just reviewing those now. I think we will still want to split the test out a a separate item.

brodycj commented 11 years ago

Cool. I just entered a couple more pull requests for your review.

On Wed, Jan 2, 2013 at 4:13 PM, Nick Parker notifications@github.comwrote:

Hi brodyspark,

Thanks - I am just reviewing those now. I think we will still want to split the test out a a separate item.

— Reply to this email directly or view it on GitHubhttps://github.com/sqlcipher/sqlcipher-android-tests/pull/1#issuecomment-11811053.

developernotes commented 11 years ago

Hi brodyspark,

We use this test suite to verify support from platform version 2.1-4.1 currently, running across different emulators. Due to the pull requests you've made, not all code is applicable across versions (e.g., Cursor.getType(...) was added in API 11). These tests would then cause build failures for lower versions that do not support that. While we appreciate the effort, we are going to hold off on merging the tests for now. Thanks!