This removes the db layer of sqlectron-core, moving it to its own package sqlectron-db-core. This separate package contains all of the DB logic and nothing else, while then sqlecton-core combines that with the info for dealing with the config files and the like that is required for sqlectron-gui. The intention here is that the changes should be as backwards compatible as possible, and this has been largely achieved, except for the setting of the default limit, which requires looking into the config file. I had debated trying to do some hacky monkey patching or other strategy to improve this, but decided to not bother. There is a function that can be called that will sort of mimic prior behavior in looking into the config file, but I think my thought is that this function be removed and it's on the client completely to always pass in a set limit to use, or else use the default one.
As part of this work, the sqlectron-db-core package only supports node >= 10.12 so switching here will require dropping support for node 6 and node 8 with a major version bump. Given how old and deprecated those versions are, that should not be a real problem for anyone.
This removes the
dblayer ofsqlectron-core, moving it to its own packagesqlectron-db-core. This separate package contains all of the DB logic and nothing else, while thensqlecton-corecombines that with the info for dealing with the config files and the like that is required forsqlectron-gui. The intention here is that the changes should be as backwards compatible as possible, and this has been largely achieved, except for the setting of the default limit, which requires looking into the config file. I had debated trying to do some hacky monkey patching or other strategy to improve this, but decided to not bother. There is a function that can be called that will sort of mimic prior behavior in looking into the config file, but I think my thought is that this function be removed and it's on the client completely to always pass in a set limit to use, or else use the default one.As part of this work, the
sqlectron-db-corepackage only supportsnode >= 10.12so switching here will require dropping support for node 6 and node 8 with a major version bump. Given how old and deprecated those versions are, that should not be a real problem for anyone.